Fix TypeError: _validateParameters is not a function#8836
Closed
Chessing234 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: Parameter validation was throwing a hard error when triggered, because
p5.prototype._validateParameterswas incorrectly aliased to the undefinedp5.validateParametersinstead ofp5._validateParameters.Root cause: The alias in
validate_params.jsreferenced an undefined property instead of the static method defined earlier in the file. This prevented the FES (Friendly Error System) from correctly logging parameter errors and instead crashed the program when it attempted to execute the wrapper.Why fix is correct: Pointing the alias to the correct static method
p5._validateParametersrestores the intended FES behavior without crashing the program, fixing Issue #8818.