Skip to content

relax fetch, remove print #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mingness merged 1 commit into from
Oct 29, 2024
Merged

relax fetch, remove print #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions scripts/fetch_updates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ def log_broken(contribution, msg):

def process_contribution(contribution):
date_today = datetime.today().strftime('%Y-%m-%d')
this_version = 0
this_version = '0'

if contribution['status'] != 'DEPRECATED':
# compare version to what is at url. If has iterated up, update contribution to
# compare version to what is at url. If has changed, update contribution to
# what is online
if 'version' in contribution:
this_version = int(contribution['version'])
this_version = contribution['version']

try:
properties_raw = read_properties_txt(contribution['source'])
Expand All @@ -53,7 +53,7 @@ def process_contribution(contribution):
log_broken(contribution, f'invalid file, {date_today}')
return

if int(props['version']) > this_version:
if props['version'] != this_version:
# update from online
update_contribution(contribution, props)
contribution['status'] = 'VALID'
Expand Down
1 change: 0 additions & 1 deletion scripts/parse_and_validate_properties_txt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ def parse_text(properties_raw):
if field_name:
properties_dict[field_name] = field_value

print(f"properites_dict={properties_dict}")
return properties_dict

def validate_existing(properties_dict):
Expand Down