copy zip to pdex, and add to workflow #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefterv
approved these changes
Aug 2, 2024
| group = "processing" | ||
| dependsOn("clean","build","javadoc", "writeLibraryProperties") | ||
| finalizedBy("packageRelease") | ||
| finalizedBy("packageRelease", "copyZipToPdex") |
Collaborator
There was a problem hiding this comment.
One note in general, not for this PR, I would like to see somewhat more standardised task naming
Collaborator
There was a problem hiding this comment.
I think I agree with you (see https://github.com/mingness/processing-library-template/issues/31). Could you be more specific what kind of standard you mean?
Collaborator
There was a problem hiding this comment.
I think you worded what I saw better in your issue
Collaborator
Author
There was a problem hiding this comment.
Yes, your suggestions are excellent. Will do.
mingness
deleted the
23-create-a-pdex-file-and-include-it-in-the-release-artifacts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have added task that copies the zip file to pdex, and included it into the releaseProcessingLib task.
Have included pdex into github action.