Skip to content

copy zip to pdex, and add to workflow #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mingness merged 1 commit into from
Aug 2, 2024
Merged

copy zip to pdex, and add to workflow #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,6 @@ jobs:
- name: Release
uses: softprops/action-gh-release@v2
with:
files: release/*.zip
files: |
release/*.zip
release/*.pdex
13 changes: 11 additions & 2 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ tasks.javadoc.get().mustRunAfter("build")
tasks.register("releaseProcessingLib") {
group = "processing"
dependsOn("clean","build","javadoc", "writeLibraryProperties")
finalizedBy("packageRelease")
finalizedBy("packageRelease", "copyZipToPdex")
Copy link
Collaborator

@Stefterv Stefterv Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note in general, not for this PR, I would like to see somewhat more standardised task naming

Copy link
Collaborator

@SableRaf SableRaf Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I agree with you (see https://github.com/mingness/processing-library-template/issues/31). Could you be more specific what kind of standard you mean?

Copy link
Collaborator

@Stefterv Stefterv Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you worded what I saw better in your issue

Copy link
Collaborator Author

@mingness mingness Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, your suggestions are excellent. Will do.


doFirst {
println("Releasing library $libName")
Expand Down Expand Up @@ -181,11 +181,20 @@ tasks.register<Zip>("packageRelease") {
dependsOn("releaseProcessingLib")
archiveFileName.set("${libName}.zip")
from(releaseDirectory)
into(libName)
into(releaseName)
destinationDirectory.set(file(releaseRoot))
exclude("**/*.DS_Store")
}

tasks.register<Copy>("copyZipToPdex") {
from(releaseRoot) {
include("$libName.zip")
rename("$libName.zip", "$libName.pdex")
}
into(releaseRoot)
}
tasks["copyZipToPdex"].mustRunAfter("packageRelease")

tasks.register("copyToLocalProcessing") {
group = "processing"
if (project.hasProperty("sketchbookLocation")) {
Expand Down