Skip to content

Fixing reference titles #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SableRaf merged 1 commit into from
Nov 30, 2022
Merged

Fixing reference titles #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/components/reference/ReferenceList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const ReferenceList = ({ tree, library }) => {
<h2
className={classnames(grid.col, css.category)}
id={slugify(category)}>
{intl.formatMessage({id:category})}
{intl.formatMessage({ id: category })}
</h2>
{Object.keys(tree[category]).map((subcategory) => {
return (
Expand All @@ -27,7 +27,10 @@ const ReferenceList = ({ tree, library }) => {
<div className={classnames(grid.col, css.subcategoryTitle)}>
{subcategory && <div className={css.line} />}
{subcategory && (
<h3 id={slugify(category, subcategory)}> {intl.formatMessage({id:subcategory})}</h3>
<h3 id={slugify(category, subcategory)}>
{' '}
{intl.formatMessage({ id: subcategory })}
</h3>
)}
</div>
<ul className={classnames(grid.col, css.subcategoryList)}>
Expand Down
1 change: 0 additions & 1 deletion src/pages/reference.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ const Reference = ({ data }) => {
title={intl.formatMessage({ id: 'reference' })}
description={intl.formatMessage({ id: 'cardReferenceDescription' })}
/>

<div className={classnames(grid.container, grid.grid)}>
<h1 className={classnames(grid.col, css.heading)}>
{intl.formatMessage({ id: 'reference' })}
Expand Down
13 changes: 8 additions & 5 deletions src/templates/reference/class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,17 @@ const ClassRefTemplate = ({ data, pageContext }) => {

const trail = useTrail(libraryName, entry?.category, entry?.subcategory);

const title =
(entry?.name ?? data.en.childJson.name) +
' / ' +
(isProcessing
? intl.formatMessage({ id: 'reference' })
: intl.formatMessage({ id: 'libraries' }));

return (
<Layout withSidebar withBreadcrumbs>
<HeadMatter
title={
(entry?.name ?? data.en.childJson.name) + ' / ' + isProcessing
? intl.formatMessage({ id: 'reference' })
: intl.formatMessage({ id: 'libraries' })
}
title={title}
description={entry?.description}
img={getImage(data.images.nodes[0])}
/>
Expand Down
13 changes: 8 additions & 5 deletions src/templates/reference/function.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,17 @@ const RefTemplate = ({ data, pageContext, ...props }) => {
entry?.classanchor
);

const title =
(entry?.name ?? data.en.childJson.name) +
' / ' +
(isProcessing
? intl.formatMessage({ id: 'reference' })
: intl.formatMessage({ id: 'libraries' }));

return (
<Layout withSidebar withBreadcrumbs>
<HeadMatter
title={
(entry?.name ?? data.en.childJson.name) + ' / ' + isProcessing
? intl.formatMessage({ id: 'reference' })
: intl.formatMessage({ id: 'libraries' })
}
title={title}
description={entry?.description}
img={getImage(data.images.nodes[0])}
/>
Expand Down