-
-
Notifications
You must be signed in to change notification settings - Fork 103
Initial FFI setup #1287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial FFI setup #1287
Conversation
app/build.gradle.kts
Outdated
|
|
||
| // TODO: Update to 2.10.20 and add hot-reloading: https://github.com/JetBrains/compose-hot-reload | ||
|
|
||
| abstract class SignResourcesTask : DefaultTask() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one! Is the intention to move this to a separate file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it probably should be in a separate file, totally. will do that....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
factored out all these into a new buildSrc dir
| // Can be deleted after the migration to Gradle is complete | ||
| layout.buildDirectory = file(".build") | ||
|
|
||
| allprojects { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a workaround until kotlin 2.3.0 is released with jdk 25 support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we leave a little TODO saying that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's more complicated now as it enforces android source level compat
|
|
||
| static { | ||
| // platform | ||
| if (OS_NAME.contains("mac") || OS_NAME.contains("darwin")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to start including Android from the start?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh yeah, good callout. i did identify that there's a plugin for building Rust/android here https://github.com/mozilla/rust-android-gradle. let me think more about this re: the binding strategy, since panama won't work there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whatever you do, I don't think android should block progress this early on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a enableWebGPU flag that enforces source level compat with android atm. we can make the call on full android support later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments! How would I try this?
I'm happy to approve and get it into our feature branch, but the TODOs tell me this is just early feedback (which I love)
Exciting work!
| // Can be deleted after the migration to Gradle is complete | ||
| layout.buildDirectory = file(".build") | ||
|
|
||
| allprojects { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we leave a little TODO saying that?
|
|
||
| static { | ||
| // platform | ||
| if (OS_NAME.contains("mac") || OS_NAME.contains("darwin")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whatever you do, I don't think android should block progress this early on.
|
|
||
| [lib] | ||
| name = "processing" | ||
| crate-type = ["cdylib"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
obsessed with what we get from rust
Closes #1270
Partially addresses #1269
TODO:
cargo cleaninto gradle.