fix(ad-hoc): Refactor coroutine scopes#219
Merged
vitalii-vanziak-cko merged 5 commits intomasterfrom Aug 23, 2024
Merged
Conversation
andrii-vysotskyi-cko
approved these changes
Aug 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored usages of coroutine scopes to apply the following rules:
mainScopeinContextGraph. It used in all services and repositories whose scope should be active throughout the whole SDK/app lifetime. It never cancels.Dispatchers.Main.immediateused only in components responsible to update the UI (activity/VM/interactor) and bound to component lifecycle.PODefaultProxy3DSService) have it's ownMainScope()which is cancelled when component is not needed anymore.lifecycleScope).