feat(POM-419): Dynamic Checkout lifecycle events#233
Merged
vitalii-vanziak-cko merged 37 commits intomasterfrom Oct 25, 2024
Merged
feat(POM-419): Dynamic Checkout lifecycle events#233vitalii-vanziak-cko merged 37 commits intomasterfrom
vitalii-vanziak-cko merged 37 commits intomasterfrom
Conversation
…ing separate coroutines
andrii-vysotskyi-cko
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored:
val original: PODynamicCheckoutPaymentMethodto all internalPaymentMethodinteractor types. It is needed for lifecycle events and make it easy to access the original type without the need to lookup for it.DynamicCheckoutInteractorStateto keep the wholePaymentMethodobject instead of only IDs for the following states (allows to avoid lookup for the object by id and simplifies the logic):selectedPaymentMethodId -> selectedPaymentMethod
processingPaymentMethodId -> processingPaymentMethod
pendingSubmitPaymentMethodId -> pendingSubmitPaymentMethod
Added:
PODynamicCheckoutEventand sending all lifecycle events.PODynamicCheckoutDelegatedispatchingpreferredScheme(for card) anddefaultValues(for nAPM).PODynamicCheckoutPaymentMethod.Display.description, it used as text for customer token payment types (card and APM) with fallback todisplay.namewhen null.logAttributesbut not used yet, logs will be added in separate PR.Jira Issue
https://checkout.atlassian.net/browse/POM-419