fix: do not rerender nAPM confirmation page when polling [POS-1633]#262
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where repeated background polling responses in the PENDING state caused the APM Pending view to re-render unnecessarily, which could reset the pending UI state (e.g., countdown/instructions).
Changes:
- Track the previous payment state before applying the newly returned
config.state. - Avoid re-rendering
APMViewPendingwhen the state remainsPENDINGacross polling cycles (PENDING → PENDING).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
szymon-mysiak-cko
changed the title
roshan-gorasia-cko
approved these changes
May 20, 2026
lukasz-k-bieszczad-cko
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When doing polling, in most cases returned responses are empty with pending state. If the initial response contained some data e.g. qr code and consequent polling responses were empty, the qr code disappeared after rerender. This PR sets the behavior that render for pending state happens only once.
Solution
Demo
Checklist
yarn bump-versionNotes
Jira Issue