Page name anomolies for page titled "Untitled 1"

[Toutouwai]

Short description of the issue

This is a weird one, and was raised by PCuser in the forums: https://processwire.com/talk/topic/19769-page-url-changes-when-page-is-saved/

This is the page tree (clean PW installation, no modules or hooks):

Note that there is only a single child page "Untitled 1" under its parent.

When that page is edited, on every save the page name changes - in this case alternating between "untitled-1" and "untitled-1-2". PCuser reported a different change where the suffix number was incrementing upwards after each save.

Also, if I manually set the page name to "untitled-2" I get a message about the name being changed because that name was already taken, but that is incorrect because there are no sibling pages that the name could clash with. This is on PW 3.0.108 so probably related to this issue: #648

Setup/Environment

• ProcessWire version: 3.0.108

[matjazpotocnik]

In my case, on save, the page name iterates between untitled-1 and untitled-1-13. It goes back to at least PW 3.0.40

[matjazpotocnik]

It looks like this is happening in PagesEditor.php in the setupPageName method. I fixed it by replacing && with || in if($pageName == $this->untitledPageName && strpos($page->name, $this->untitledPageName) === 0) { I'm not sure if this is how it should be fixed...

[ryancramerdesign]

I'm not currently seeing this issue, but I think it might be because a lot of the code for this stuff was completely replaced with the addition of the PagesNames class to the core. Are you still seeing the issue there on the most recent core dev branch versions? Thanks.

[Toutouwai]

The first part of this issue (the page name changing on every save) seems to be solved, but the second part is not solved in PW 3.0.112:

Also, if I manually set the page name to "untitled-2" I get a message about the name being changed because that name was already taken, but that is incorrect because there are no sibling pages that the name could clash with.

See the screencast below - the page being saved has no siblings:

[netcarver]

@ryancramerdesign Bumping this for your further consideration.

[ryancramerdesign]

@Toutouwai @netcarver I can't seem to reproduce that one. I'm able to create a page with name untitled-2 no problem here. Any other conditions present you can think of?

[Toutouwai]

I'm able to create a page with name untitled-2 no problem here.

The issue isn't with creating a page named untitled-2, it's with changing the name of a page titled untitled-1 to untitled-2.

I retested in the latest v3.0.127 and the issue remains.

Only a single page under the parent (no page named untitled-2):

Rename fails:

[matjazpotocnik]

Looking this method at in PageNames.php

	/**
	 * Check given page’s name for conflicts and increment as needed while also triggering a warning notice
	 * 
	 * @param Page $page
	 * @since 3.0.127
	 * 
	 */
	public function checkNameConflicts(Page $page) {
        ...
            $page->name = $page->namePrevious;
        ...
        }

Shouldn't that $page parameter be passed by reference?

But the cause of this "untitled" issue is in PagesEditor.php in savePageQuery():

		if($this->pages->names()->isUntitledPageName($page->name)) {
			$this->pages->setupPageName($page);
		}

That eventually call pageNameFromFormat() method and that set the page name from your title "Untitled 1". Perhaps we shouldn't use the word "untitled" as the title or name? Or maybe this:

		if($isNew && $this->pages->names()->isUntitledPageName($page->name)) {
			$this->pages->setupPageName($page);
		}