Add a JavaScriptHooks module to the core for modules to depend on #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poljpocket
commented
Aug 19, 2025
Comment on lines
+38
to
+39
| onSelect: ___selected, | ||
| onClose: ___closed, |
There was a problem hiding this comment.
@BernhardBaumrock am I doing this correctly here? Or what would the correct callback be for it to be hookable?
There was a problem hiding this comment.
Looking at it again, I think, I need to do something like this:
// assume $thisobject is the InputfieldDatetimeDatepicker object
onSelect: function(datetime, $datepicker) {
$thisobject.selected(datetime, $datepicker);
}
onClose: function(datetime, $datepicker) {
$thisobject.closed(datetime, $datepicker);
}
poljpocket
commented
Aug 19, 2025
| // init datepickers present when document is ready | ||
| $("input.InputfieldDatetimeDatepicker:not(.InputfieldDatetimeDatepicker3):not(.initDatepicker)").each(function(n) { | ||
| InputfieldDatetimeDatepicker($(this)); | ||
| ProcessWire.wire(InputfieldDatetimeDatepicker($(this))); |
There was a problem hiding this comment.
InputfieldDatetimeDatepicker might need to be a class or return itself at the end...
poljpocket
commented
Aug 19, 2025
| // init datepicker that should appear on focus (3) of text input, that wasn't present at document.ready | ||
| $(document).on('focus', 'input.InputfieldDatetimeDatepicker3:not(.hasDatepicker)', function() { | ||
| InputfieldDatetimeDatepicker($(this)); | ||
| ProcessWire.wire(InputfieldDatetimeDatepicker($(this))); |
There was a problem hiding this comment.
InputfieldDatetimeDatepicker might need to be a class or return itself at the end...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR which adds JavaScript hooks to the core. Based on #322.
For more details about what this is trying to achieve, see https://processwire.com/talk/topic/30365-lets-bring-hooks-to-javascript/
This includes a small example for InputfieldDateTime which exposes two example hooks for when a date is selected and when the datepicker is closed.