Skip to content

Add possibility to block users to securite role#1254

Merged
BenoitSerrano merged 1 commit into
mainfrom
add-moderations-to-securite-role
Jun 22, 2026
Merged

Add possibility to block users to securite role#1254
BenoitSerrano merged 1 commit into
mainfrom
add-moderations-to-securite-role

Conversation

@BenoitSerrano

Copy link
Copy Markdown
Contributor

No description provided.

@BenoitSerrano BenoitSerrano marked this pull request as draft June 16, 2026 13:29
@BenoitSerrano BenoitSerrano force-pushed the add-moderations-to-securite-role branch from e07ee78 to 602b1b8 Compare June 16, 2026 13:31
@BenoitSerrano BenoitSerrano force-pushed the add-moderations-to-securite-role branch from 7fefbc2 to 4836cdc Compare June 16, 2026 22:49
@BenoitSerrano BenoitSerrano marked this pull request as ready for review June 16, 2026 22:49
@BenoitSerrano

Copy link
Copy Markdown
Contributor Author

@BenoitSerrano BenoitSerrano changed the title Add moderations to securite role Add possibility to block users to securite role Jun 16, 2026
@BenoitSerrano BenoitSerrano force-pushed the add-moderations-to-securite-role branch from 4836cdc to 4ce2c56 Compare June 17, 2026 08:11

@rdubigny rdubigny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome!

Comment thread admin/src/federation-user/federation-user.service.ts Outdated
Comment thread admin/views/federation-user/list.ejs Outdated
@@ -1,20 +1,29 @@
<div class=" float-end">
<form class="d-flex align-items-center" id="search-form" data-init="validForm" method="GET" novalidate>
<div class="float-end">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: This linter of yours sounds useful 😉

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that I should run it throughout the whole project? :)

Et que je clique sur le bouton ProConnect
Et que j'entre l'email "user-deactivated@fia1.fr"
Et que je clique sur le bouton de connexion
Et que j'utilise l'identité avec le sub "e3322382e75c0d0a8e95f80af703932bd3c38f940aa59ad08b1cb4900998578c"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: I was expecting to read:

Suggested change
Et que j'utilise l'identité avec le sub "e3322382e75c0d0a8e95f80af703932bd3c38f940aa59ad08b1cb4900998578c"
Et que j'utilise l'identité avec le sub "d68cec59-ed65-48ab-bfbf-1ca65dd807f8"

To be consistent with line 9.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand why you would expect that héhé
When I block a user, I block their Federation sub (I don't want to allow them to log in with another IdP, do I?)
When I log in as a specific user via the test idp, I can only return a specific idp sub.

The idp e3322382e75c0d0a8e95f80af703932bd3c38f940aa59ad08b1cb4900998578c *idp sub *corresponds to the d68cec59-ed65-48ab-bfbf-1ca65dd807f8 federation sub.
What I offer at best would be a comment that explains this. Was meinst du dazu?

Comment thread quality/cypress-base.config.ts Outdated
@BenoitSerrano BenoitSerrano force-pushed the add-moderations-to-securite-role branch from 4ce2c56 to 50fbc2f Compare June 22, 2026 14:12
**Problem**
The Security Operations Center (SOC) needs a way to quickly block a user account in emergency situations.

**Proposal**
Add an interface in the admin panel that allows authorized administrators to block a user.
@BenoitSerrano BenoitSerrano force-pushed the add-moderations-to-securite-role branch from 50fbc2f to 9e5ac59 Compare June 22, 2026 15:26
@BenoitSerrano BenoitSerrano merged commit 9c82e57 into main Jun 22, 2026
16 checks passed
@BenoitSerrano BenoitSerrano deleted the add-moderations-to-securite-role branch June 22, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants