Update docs regarding the args yielded to blocks#108
Merged
philipqnguyen merged 1 commit intomasterfrom Oct 18, 2018
Merged
Conversation
philipqnguyen
requested review from
AllPurposeName,
adamwells,
dlcarter,
mcclayton,
njbbaer and
wai-procore
Contributor
|
Very nice 👍 |
mcclayton
approved these changes
Oct 18, 2018
mcclayton
reviewed
Oct 18, 2018
| # to the :default view. | ||
| # @yield [Object] The object passed to `render` is also passed to the | ||
| # block. | ||
| # @yield [object, options] The object and the options passed to render is |
Contributor
There was a problem hiding this comment.
Oh, perhaps are instead of is.
| # The method, proc or string should return or evaluate to a true or false value. | ||
| # @yield [Object] The object passed to `render` is also passed to the | ||
| # block. | ||
| # @yield [object, options] The object and the options passed to render is |
Contributor
There was a problem hiding this comment.
Oh, perhaps are instead of is.
The blocks are yielded both the object and the options that were passed to render. This commit simply ensure that the docs reflects that.
philipqnguyen
force-pushed
the
fix-block-docs
branch
from
735f25b to
8cc0f27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blocks are yielded both the object and the options that were passed
to render. This commit simply ensure that the docs reflects that.