Localize private flag to class and not module#111
Merged
mcclayton merged 1 commit intoprocore-oss:masterfrom Oct 26, 2018
Merged
Localize private flag to class and not module#111mcclayton merged 1 commit intoprocore-oss:masterfrom
mcclayton merged 1 commit intoprocore-oss:masterfrom
Conversation
This private flag was accidentally placed that the top level module, causing many methods and classes set at the top level to be considered private when it shouldn't have been. Take a look at https://www.rubydoc.info/gems/blueprinter/Blueprinter it has the `configure` method as private, when it should be public. Moving this private flag down to the Extractor class level should fix this.
mcclayton
approved these changes
Oct 26, 2018
wai-procore
approved these changes
Oct 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This private flag was accidentally placed at the top level module,
causing many methods and classes set at the top level to be considered
private when it shouldn't have been.
Take a look at https://www.rubydoc.info/gems/blueprinter/Blueprinter
it has the
configuremethod as private, when it should be public.Moving this private flag down to the Extractor class level should
fix this.