do not raise error on null date with date_format option (closes #116)#117
Merged
mcclayton merged 2 commits intoprocore-oss:masterfrom Nov 19, 2018
tpltn:master
Merged
do not raise error on null date with date_format option (closes #116)#117mcclayton merged 2 commits intoprocore-oss:masterfrom tpltn:master
mcclayton merged 2 commits intoprocore-oss:masterfrom
tpltn:master
Conversation
Contributor
|
associating this to #116 |
philipqnguyen
suggested changes
Nov 15, 2018
| expect(blueprint.render_as_hash(object)).to eq(date: nil) | ||
| end | ||
| end | ||
| end |
Contributor
There was a problem hiding this comment.
There's already a context for datetime. Would you augment that context to include this test instead of putting this test here?
philipqnguyen
approved these changes
Nov 16, 2018
njbbaer
approved these changes
Nov 17, 2018
mcclayton
approved these changes
Nov 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.