render_as_json, making sorting fields optional#119
Merged
AllPurposeName merged 9 commits intoprocore-oss:masterfrom Dec 6, 2018
ritikesh:master
Merged
render_as_json, making sorting fields optional#119AllPurposeName merged 9 commits intoprocore-oss:masterfrom ritikesh:master
AllPurposeName merged 9 commits intoprocore-oss:masterfrom
ritikesh:master
Conversation
Collaborator
Author
|
@philipqnguyen @mcclayton |
mcclayton
reviewed
Nov 28, 2018
Contributor
|
Thanks so much for your valuable contribution @ritikesh. Apologies for the delay in reviewing, been a little slow with the holidays 🦃 |
mcclayton
reviewed
Nov 28, 2018
Collaborator
Author
No worries, hope had a good time there. 😄 |
Collaborator
Author
|
@mcclayton I've made the changes as suggested. Please let me know if you need anything else. |
mcclayton
reviewed
Nov 30, 2018
mcclayton
approved these changes
Nov 30, 2018
philipqnguyen
approved these changes
Dec 4, 2018
Collaborator
Author
|
Hi guys, is there anything pending on this? @philipqnguyen @mcclayton |
AllPurposeName
approved these changes
Dec 6, 2018
Contributor
AllPurposeName
left a comment
There was a problem hiding this comment.
Looks great, thanks for making those changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
render_as_jsonAPI - When you want a JSONified hash - useful when you want to modify the generated hash but require it to be JSONifiedrender_as_hash,exclude..