Modify Extractor access control#182
Merged
mcclayton merged 6 commits intoprocore-oss:masterfrom Sep 19, 2019
Merged
Conversation
Signed-off-by: Carlos Adrian Gomez <cagomez805@gmail.com>
Signed-off-by: Carlos Adrian Gomez <cagomez805@gmail.com>
Signed-off-by: Carlos Adrian Gomez <cagomez805@gmail.com>
Signed-off-by: Carlos Adrian Gomez <cagomez805@gmail.com>
Signed-off-by: Carlos Adrian Gomez <cagomez805@gmail.com>
Signed-off-by: Carlos Adrian Gomez <cagomez805@gmail.com>
philipqnguyen
approved these changes
Sep 19, 2019
mcclayton
approved these changes
Sep 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom Extractor classes are already being used in production and the Private API warning in the docs is confusing for developers.
https://www.rubydoc.info/gems/blueprinter/Blueprinter/Extractor
Also makes prebuilt classes inheriting from Extractor private (from a previous PR comment).