Skip to content

Configure extractor#198

Merged
philipqnguyen merged 3 commits intoprocore-oss:masterfrom
wlkrw:configure-extractor
Jan 29, 2020
Merged

Configure extractor#198
philipqnguyen merged 3 commits intoprocore-oss:masterfrom
wlkrw:configure-extractor

Conversation

@wlkrw
Copy link
Copy Markdown
Contributor

@wlkrw wlkrw commented Jan 29, 2020

This is a fix for #178.

Since I've never personally needed this, I'm afraid the example added to README.md does not do a great job motivating why to use this feature. I'm open to suggestions or edits.

Copy link
Copy Markdown
Contributor

@philipqnguyen philipqnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! @wlkrw

Copy link
Copy Markdown
Contributor

@mcclayton mcclayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this @wlkrw, looks great 😄

@philipqnguyen philipqnguyen merged commit 5d82c70 into procore-oss:master Jan 29, 2020
@philipqnguyen
Copy link
Copy Markdown
Contributor

released in 0.23.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants