Setting view causes state change on default view#204
Merged
mcclayton merged 1 commit intoprocore-oss:masterfrom Mar 16, 2020
trevorrjohn:view-state
Merged
Setting view causes state change on default view#204mcclayton merged 1 commit intoprocore-oss:masterfrom trevorrjohn:view-state
mcclayton merged 1 commit intoprocore-oss:masterfrom
trevorrjohn:view-state
Conversation
trevorrjohn
changed the title
Contributor
Author
|
So I found the issue, |
|
Hi Trevor. Thanks so much for contributing. We'll take a look soon. |
philipqnguyen
approved these changes
Mar 16, 2020
Contributor
|
lgtm |
Contributor
|
whoops didnt mean to accidentally close this |
mcclayton
approved these changes
Mar 16, 2020
Contributor
Author
|
No rush, but as this is a bug fix I would love to get this merged and released so that I don't have to maintain a fork. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fails at this moment I was hoping someone could help me debug why it fails.