Merged
Conversation
mcclayton
approved these changes
Apr 28, 2020
Contributor
mcclayton
left a comment
mcclayton
left a comment
There was a problem hiding this comment.
Looks good to me! Minor comments about naming since the gem is Blueprinter and utilizes Blueprints.
Co-Authored-By: Michael Clayton <mcclayton@users.noreply.github.com>
cagmz
reviewed
Apr 29, 2020
Co-Authored-By: Carlos Adrian Gomez <cagmz@users.noreply.github.com>
cagmz
approved these changes
Apr 29, 2020
mcclayton
approved these changes
Apr 29, 2020
Contributor
Author
|
@mcclayton Thanks for the review! Any requirements for testing? Specs are green , but is there anything else needed? |
Contributor
|
I think it's all good to merge, but might be nice for @philipqnguyen to take a look to make sure this is something we want to expose, but I think it's good 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.