Conversation
Contributor
Author
|
Note: All versions of Ruby are EOL, we should look at changing CI to accept 2.7+ only. |
lessthanjacob
approved these changes
Jun 21, 2023
jmeridth
force-pushed
the
jm/github-ations-etc
branch
from
8aa3605 to
dee4235
Compare
jmeridth
force-pushed
the
jm/github-ations-etc
branch
from
dee4235 to
0aa6f82
Compare
jmeridth
force-pushed
the
jm/github-ations-etc
branch
2 times, most recently
from
c23a799 to
f7fa712
Compare
Contributor
Author
|
Looks like the current github action failures (ruby 2.2) are related to this. No fix available. Going to go back to newer versions of ruby. |
jmeridth
force-pushed
the
jm/github-ations-etc
branch
5 times, most recently
from
4c8a140 to
698fc52
Compare
Closed
Contributor
Author
|
This is working with 2.7 but fails with ruby 3.0+. Will fix for 3.0+ and handle 2.7 retroactively due to known legacy apps that are using blueprinter. |
- [x] github actions for tests and release instead of circleci - [ ] add secrets to repository - [x] dependabot - [x] stale github action - [x] auto assign author github action - [x] update README tests badge - [x] add CONTRIBUTING.md, CODE_OF_CONDUCT.md, and .github/PULL_REQUEST_TEMPLATE.md Signed-off-by: jmeridth <jmeridth@gmail.com>
jmeridth
force-pushed
the
jm/github-ations-etc
branch
from
698fc52 to
3f71e9e
Compare
…matrix Signed-off-by: jmeridth <jmeridth@gmail.com>
Contributor
Author
|
@lessthanjacob fixing the build failures. Awesome. Thank you.
just need to figure out what the bot email and name are and if they are still needed. This |
Signed-off-by: jmeridth <jmeridth@gmail.com>
- [x] add specific filenames to pull request template - [x] add blurb about this PR to changelog (will need to modify date once ready) Signed-off-by: jmeridth <jmeridth@gmail.com>
Signed-off-by: jmeridth <jmeridth@gmail.com>
Signed-off-by: jmeridth <jmeridth@gmail.com>
Signed-off-by: jmeridth <jmeridth@gmail.com>
- [x] only release if a change occurred to the lib/blueprinter/version.rb file - [x] change test job from test-ruby2 to just test Signed-off-by: jmeridth <jmeridth@gmail.com>
this allows dependabot to automate updates when new releases occur Signed-off-by: jmeridth <jmeridth@gmail.com>
jamesmcguirepro
approved these changes
Jul 27, 2023
can decide if we want a new gem later after other PRs merge Signed-off-by: jmeridth <jmeridth@gmail.com>
Signed-off-by: jmeridth <jmeridth@gmail.com>
lessthanjacob
approved these changes
Jul 28, 2023
Signed-off-by: jmeridth <jmeridth@gmail.com>
Contributor
Author
|
@lessthanjacob @jamesmcguirepro I simplified the release github action. One more review and this is ready to merge IMO. |
jamesmcguirepro
approved these changes
Jul 28, 2023
philipqnguyen
added a commit
to philipqnguyen/blueprinter
that referenced
this pull request
Aug 17, 2023
This releases the gem to 0.27.0. It drops support for any ruby version less than 2.7. See procore-oss#307 Signed-off-by: philipqnguyen <philip.nguyen@procore.com>
philipqnguyen
added a commit
to philipqnguyen/blueprinter
that referenced
this pull request
Aug 17, 2023
This releases the gem to 0.26.0. It drops support for any ruby version less than 2.7. See procore-oss#307 Signed-off-by: philipqnguyen <philip.nguyen@procore.com>
philipqnguyen
added a commit
to philipqnguyen/blueprinter
that referenced
this pull request
Aug 17, 2023
This releases the gem to 0.26.0. It drops support for any ruby version less than 2.7. See procore-oss#307 Signed-off-by: Philip Nguyen <philip.nguyen@procore.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stale github actionpostponing until we've reviewed all existing issues and PRs