Add extensions with initial support for pre_render#358
Merged
jhollinger merged 6 commits intoprocore-oss:mainfrom Jan 17, 2024
jhollinger:extensions
Merged
Add extensions with initial support for pre_render#358jhollinger merged 6 commits intoprocore-oss:mainfrom jhollinger:extensions
jhollinger merged 6 commits intoprocore-oss:mainfrom
jhollinger:extensions
Conversation
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
ritikesh
reviewed
Nov 20, 2023
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
ritikesh
reviewed
Dec 15, 2023
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
ritikesh
approved these changes
Jan 4, 2024
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
lessthanjacob
approved these changes
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial attempt at a formal extension API as part of #341. I've built a POC ActiveRecord automagic preloader against this and #357.
In this proposal, an "extension" is a class inheriting from
Blueprinter::Extensionand passed toBlueprinter.configure. This PR defines only one extension method:pre_render. It intercepts whatever is passed to.renderand returns (potentially) a modified result.In the simplified version of my POC below, the extension figures out which associations to preload from the Blueprint view (using reflection), and returns the
ActiveRecord::Relationwithpreloadcalled.