Allowing to use included views transformer from the current view#363
Allowing to use included views transformer from the current view#363bhooshiek-narendiran wants to merge 7 commits intoprocore-oss:mainfrom
Conversation
Signed-off-by: bhooshiek <bhooshiek.narendiran@freshworks.com>
bhooshiek-narendiran
requested review from
a team and
ritikesh
as code owners
lessthanjacob
left a comment
lessthanjacob
left a comment
There was a problem hiding this comment.
Thanks for revisiting this!
Since we're altering behavior here, could we some additional test assertions? You might be able to repurpose #247
njbbaer
force-pushed
the
nested_transformers
branch
2 times, most recently
from
2099353 to
e3c8ecc
Compare
|
@bhooshiek-narendiran I'm hoping to move on this fix soon, so I've opened a new PR with some changes and tests. It's based on your commits, so they aren't lost. Please comment there if you have feedback, and let me know if you were planning any additional changes we can merge together. |
Co-authored-by: Nate Baer <njbbaer@gmail.com> Signed-off-by: bhooshiek <bhooshiek.narendiran@freshworks.com>
Yes, we can merge this. I wrote the test. Facing some issues in local. Will try to complete it. |
…/blueprinter into nested_transformers
Co-authored-by: Nate Baer <njbbaer@gmail.com> Signed-off-by: bhooshiek <bhooshiek.narendiran@freshworks.com>
…/blueprinter into nested_transformers
3 participants
:
Fix for 225