Prevent re-adding same transformers to the view all the time#381
Merged
lessthanjacob merged 1 commit intoprocore-oss:mainfrom Jan 19, 2024
Merged
Prevent re-adding same transformers to the view all the time#381lessthanjacob merged 1 commit intoprocore-oss:mainfrom
lessthanjacob merged 1 commit intoprocore-oss:mainfrom
Conversation
Signed-off-by: Pritilender <sajn_ap@live.com>
lessthanjacob
approved these changes
Jan 19, 2024
Contributor
lessthanjacob
left a comment
There was a problem hiding this comment.
Thanks for opening a PR to address this! The change seems reasonable to me, but in the meantime, could you add some before-and-after benchmarks to the PR?
Contributor
Author
|
The benchmark with current code from master fails after a few minutes of running: After applying the changes, the benchmark passes again with the usual number for IPS on the basic benchmark: |
jmeridth
approved these changes
Jan 19, 2024
jhollinger
approved these changes
Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While updating to the latest version, I've noticed that performance for rendering a blueprint with a transformer has worsened significantly. Digging around the code, I found that the issue is the usage of
concatmethod which keeps adding and adding same transformers to the view on each call fetching defined transformers. This change is using simple array deconstructing to ensure immutability of the transformers array.I've also added a case with a transformer to the basic benchmark spec because I think it's valuable to also have such a case there. Let me know if I need to make it more detailed or to also add it to other benchmark specs.
Checklist: