docs: update Transform examples#415
Merged
lessthanjacob merged 2 commits intoprocore-oss:mainfrom Jun 20, 2024
Merged
Conversation
SaxtonDrey
commented
May 25, 2024
Contributor
lessthanjacob
left a comment
There was a problem hiding this comment.
Thanks for opening this!
Reading through these docs again, I think this example is unnecessarily confusing generally. We could remove the custom_columns method entirely, and rework dynamic_fields to make this a bit easier to follow (i.e. more explicit). Something like:
class User
def dynamic_fields
case role
when :admin
{
employer: employer,
time_in_role: determine_time_in role
}
when :maintainer
{
label: label,
settings: generate_settings_hash
}
when :read_only
{
last_login_at: last_login_at
}
end
end
endcc88164 to
77ecb12
Compare
Signed-off-by: SaxtonDrey <4phantomron@gmail.com>
Signed-off-by: saxtondrey <4phantomron@gmail.com>
818640c to
3caf726
Compare
Contributor
Author
|
Thanks for your review and suggestion! |
lessthanjacob
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While learning how to use Blueprinter, I encountered some confusion with the current code examples.
The concepts are well-explained, but there appears to be a discrepancy with the method names used in the examples.
Checklist: