Skip to content

Feature: Discard nil value field#425

Merged
lessthanjacob merged 10 commits intoprocore-oss:mainfrom
jamesst20:discard_nil_field
Jul 11, 2024
Merged

Feature: Discard nil value field#425
lessthanjacob merged 10 commits intoprocore-oss:mainfrom
jamesst20:discard_nil_field

Conversation

@jamesst20
Copy link
Copy Markdown
Contributor

@jamesst20 jamesst20 commented Jun 13, 2024 •
edited
Loading

Closes #424

Checklist:

  • [OK] I have updated the necessary documentation
  • [OK] I have signed off all my commits as required by DCO
  • [OK] My build is green

@jamesst20
Feature: Discard nil value field
3cb4fde 
Signed-off-by: James St-Pierre <jamesst20@gmail.com>
@jamesst20 jamesst20 requested review from a team and ritikesh as code owners June 13, 2024 14:52
@jamesst20 jamesst20 mentioned this pull request Jun 13, 2024
Closed
1 task
lessthanjacob
lessthanjacob reviewed Jun 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lessthanjacob lessthanjacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this and helping add some additional configurability to Blueprinter!

Most of my comments are primarily around naming, but happy to discuss further!

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md
Comment thread lib/blueprinter/helpers/base_helpers.rb Outdated
Comment thread spec/integrations/shared/base_render_examples.rb Outdated
Comment thread spec/integrations/shared/base_render_examples.rb Outdated
Comment thread spec/integrations/shared/base_render_examples.rb Outdated
jamesst20 and others added 2 commits June 18, 2024 11:44
@jamesst20 @lessthanjacob
Update README, Rename to exclude_if_nil, Update specs.
32cd4c0 
Co-authored-by: Jake Sheehy <jacobjsheehy@gmail.com>
Signed-off-by: James St-Pierre <jamesst20@gmail.com>
@jamesst20
Spec: Move spec outside base_render_exemples as requested
1a70e3e 
Signed-off-by: James St-Pierre <jamesst20@gmail.com>
@jamesst20
Copy link
Copy Markdown
Contributor Author

jamesst20 commented Jun 18, 2024

Thank you for opening this and helping add some additional configurability to Blueprinter!

Most of my comments are primarily around naming, but happy to discuss further!

Thanks for the quick review! Very much appreciated. I have applied all of your recommandations, after all I don't know much about this project conventions so I will stick to yours :)

lessthanjacob
lessthanjacob reviewed Jun 24, 2024
View reviewed changes
Comment thread spec/integrations/base_spec.rb
@jamesst20 @lessthanjacob
Update spec/integrations/base_spec.rb
9e77b98 
Co-authored-by: Jake Sheehy <jacobjsheehy@gmail.com>
Signed-off-by: James St-Pierre <jamesst20@gmail.com>
lessthanjacob
lessthanjacob previously approved these changes Jul 1, 2024
View reviewed changes
@jamesst20
Copy link
Copy Markdown
Contributor Author

jamesst20 commented Jul 9, 2024

Hey @lessthanjacob

May I kindly bump this and ask what's the next step now that is has your approval?

@lessthanjacob
Copy link
Copy Markdown
Contributor

lessthanjacob commented Jul 10, 2024

Hey @jamesst20! I believe I may have suggested some changes to the tests that weren't totally valid syntax-wise. Do you mind addressing those locally and pushing up a fix? Apologies for that!

jamesst20 added 2 commits July 10, 2024 11:01
@jamesst20
Merge branch 'main' into discard_nil_field
49c56bb
@jamesst20
Fix specs
04f4705 
Signed-off-by: James St-Pierre <jamesst20@gmail.com>
@jamesst20
Copy link
Copy Markdown
Contributor Author

jamesst20 commented Jul 10, 2024 •
edited
Loading

@lessthanjacob It's done! :) Indeed there was an extra , at the end of a line

Capture d’écran, le 2024-07-10 à 11 05 26

@lessthanjacob lessthanjacob merged commit c19d1dd into procore-oss:main Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lessthanjacob lessthanjacob lessthanjacob approved these changes

@ritikesh ritikesh Awaiting requested review from ritikesh ritikesh is a code owner

Assignees

@jamesst20 jamesst20

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[With PR][Feature Request] Discard blank attribute

2 participants

@jamesst20 @lessthanjacob