[Bug Fix] Fallback to :default view if nil is provided on render#472
Merged
lessthanjacob merged 1 commit intomainfrom Oct 3, 2024
Merged
[Bug Fix] Fallback to :default view if nil is provided on render#472lessthanjacob merged 1 commit intomainfrom
lessthanjacob merged 1 commit intomainfrom
Conversation
Signed-off-by: Jacob Sheehy <jacobjsheehy@gmail.com>
lessthanjacob
requested review from
friscomm,
jhollinger,
njbbaer and
ryanmccarthypdx
friscomm
approved these changes
Oct 3, 2024
lessthanjacob
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Fixes #471
Changelog
:defaultifoptionshash contains aviewkey, but the value is "false-y".Follow Ups
The test suite has become a bit of a mess, and I fear that we're introducing unintended regressions as a result. Will open an issue to try rework/restructure the tests.