Extract Rendering Functionality and Remove BaseHelpers Module#476
Merged
lessthanjacob merged 5 commits intomainfrom Jan 2, 2025
Merged
Extract Rendering Functionality and Remove BaseHelpers Module#476lessthanjacob merged 5 commits intomainfrom
lessthanjacob merged 5 commits intomainfrom
Conversation
lessthanjacob
force-pushed
the
refactor-rendering
branch
from
0938066 to
ee09ecd
Compare
Signed-off-by: Jacob Sheehy <jacobjsheehy@gmail.com>
lessthanjacob
force-pushed
the
refactor-rendering
branch
from
ee09ecd to
e39f3c8
Compare
Signed-off-by: Jacob Sheehy <jacobjsheehy@gmail.com>
jhollinger
reviewed
Oct 17, 2024
Signed-off-by: Jacob Sheehy <jacobjsheehy@gmail.com>
lessthanjacob
force-pushed
the
refactor-rendering
branch
from
0f45a4b to
f89ad2c
Compare
jhollinger
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #432
Checklist:
Changelog
RenderingmoduleBaseHelpersmoduleBaseclass withclass << selfsyntaxprepare_objecttohashifyto better match expectations.