Skip to content

feat: Add 400 response code as a bad request error #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2018
Merged

feat: Add 400 response code as a bad request error #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## Unreleased

* Add 400 responses as Procore::InvalidRequestError

## 0.7.1 (February 22, 2018)

* Fix redis store guard clause
Expand Down
2 changes: 1 addition & 1 deletion lib/procore/requestable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def with_response_handling
"exist.",
response: response,
)
when 422
when 400, 422
raise Procore::InvalidRequestError.new(
"Bad Request.",
response: response,
Expand Down