[ZL-874] Manually refresh and revoke tokens#39
Merged
Conversation
PatKoperwas
reviewed
Mar 4, 2021
PatKoperwas
reviewed
Mar 4, 2021
PatKoperwas
approved these changes
Mar 5, 2021
Contributor
Author
|
Thanks for reviewing @PatKoperwas, but I still need to add the revoke functionality before I'll request review and merge it. |
Contributor
Author
|
@PatKoperwas I finished the |
PatKoperwas
reviewed
Mar 9, 2021
gilmcquillan
reviewed
Mar 9, 2021
gilmcquillan
reviewed
Mar 9, 2021
Contributor
Author
|
@PatKoperwas @gilmcquillan Thank you for the comments, I've updated it. |
| end | ||
| end | ||
|
|
||
| def revoke |
There was a problem hiding this comment.
Did you want to add a comment above def revoke
# @raise [OAuthError] if a token cannot be revoked.
gilmcquillan
approved these changes
Mar 10, 2021
Contributor
Author
|
Thanks for the reviews. I'll merge this as soon as I'm satisfied it works with the sample app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: ZL-874
This PR adds functionality to allow clients to manually refresh and revoke their token.
Pretty simple: