[AGX-814] Fix bugs with token refresh and Oauth2 URL#52
Merged
Conversation
gilmcquillan
approved these changes
Apr 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two bug fixes for the Procore Ruby SDK:
Fix token refresh
When a token was automatically refreshed, the first request would fail. The token is now updated in memory so this will not occur.
Resolves issue: #51
Fix Oauth2 URL
The path fragment
/oauth/tokenwas incorrectly inserted into thehostURL when the Oauth2 client is initialized. Older versions of Oauth2 apparently stripped this out, but not the recent version I was using.