step-20: stale-help-fix#22
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e4117013a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| --- | ||
| step: 20 | ||
| title: stale-help-fix | ||
| depends_on: [03, 05, 07, 08, 09] |
There was a problem hiding this comment.
List all prerequisites for this final step
Because step execution relies on depends_on to decide what prior work must be present, this can be scheduled immediately after step 09 even though the text says it is a final post-step-19 patch and the verification invokes later-step artifacts such as make check-version-sync, make npm-pack-check, and make nix-smoke. In that premature execution context, those files/targets may not exist yet and the step either fails for unrelated reasons or asks the agent to operate against the wrong CLI state; make this depend on the completed build chain (e.g. step 19, or all required later steps) so the frontmatter matches the stated prerequisites.
Useful? React with 👍 / 👎.
…n test The top-level usage block in lib/clast/clast-lib.bash labeled projects, sessions, show, entries, breadcrumb, and registry as "(planned)" since step 03 — each shipping step missed updating it. Drop the suffixes and add a dispatcher-test invariant so future adds either ship with a dispatcher branch or fail CI immediately.
Codex review on PR #22 flagged that depends_on listed only the subcommand-shipping steps (03, 05, 07, 08, 09) while the verification block invokes make check-version-sync (16), make npm-pack-check (16), and make nix-smoke (15). Add 15, 16, and 19 so the frontmatter matches the actual prerequisites.
|
Addressed in 89a7f9c — widened |
Summary
Final follow-up after the v1 build series — drop the stale
(planned)labels inclast --helpfor six subcommands that have shipped (projects,sessions,show,entries,breadcrumb,registry) and add a regression test so the next subcommand-add can't reintroduce the drift.This step is outside the original 19-step plan in
docs/build-steps.md; it's a small patch flagged at the end of step 19.Test plan
bin/clast --helpoutput contains no(planned)substringbin/clasttest/enforces both invariants and is wired intomake testmake lint,make test,make check-version-syncexit 0make npm-pack-check/make nix-smokeexit 0 or skip cleanlypackage.jsonandflake.nixremain at0.0.0