Skip to content

step-20: stale-help-fix#22

Merged
simensen merged 3 commits into
mainfrom
step-20-stale-help-fix
Jun 2, 2026
Merged

step-20: stale-help-fix#22
simensen merged 3 commits into
mainfrom
step-20-stale-help-fix

Conversation

@simensen
Copy link
Copy Markdown
Contributor

@simensen simensen commented Jun 2, 2026

Summary

Final follow-up after the v1 build series — drop the stale (planned) labels in clast --help for six subcommands that have shipped (projects, sessions, show, entries, breadcrumb, registry) and add a regression test so the next subcommand-add can't reintroduce the drift.

This step is outside the original 19-step plan in docs/build-steps.md; it's a small patch flagged at the end of step 19.

Test plan

  • bin/clast --help output contains no (planned) substring
  • Every subcommand listed in help has a matching dispatcher case in bin/clast
  • A test under test/ enforces both invariants and is wired into make test
  • make lint, make test, make check-version-sync exit 0
  • make npm-pack-check / make nix-smoke exit 0 or skip cleanly
  • package.json and flake.nix remain at 0.0.0

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e4117013a0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/steps/step-20-stale-help-fix.md Outdated
---
step: 20
title: stale-help-fix
depends_on: [03, 05, 07, 08, 09]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge List all prerequisites for this final step

Because step execution relies on depends_on to decide what prior work must be present, this can be scheduled immediately after step 09 even though the text says it is a final post-step-19 patch and the verification invokes later-step artifacts such as make check-version-sync, make npm-pack-check, and make nix-smoke. In that premature execution context, those files/targets may not exist yet and the step either fails for unrelated reasons or asks the agent to operate against the wrong CLI state; make this depend on the completed build chain (e.g. step 19, or all required later steps) so the frontmatter matches the stated prerequisites.

Useful? React with 👍 / 👎.

simensen added 2 commits June 2, 2026 14:24
…n test

The top-level usage block in lib/clast/clast-lib.bash labeled
projects, sessions, show, entries, breadcrumb, and registry as
"(planned)" since step 03 — each shipping step missed updating it.
Drop the suffixes and add a dispatcher-test invariant so future
adds either ship with a dispatcher branch or fail CI immediately.
Codex review on PR #22 flagged that depends_on listed only the
subcommand-shipping steps (03, 05, 07, 08, 09) while the verification
block invokes make check-version-sync (16), make npm-pack-check (16),
and make nix-smoke (15). Add 15, 16, and 19 so the frontmatter
matches the actual prerequisites.
@simensen
Copy link
Copy Markdown
Contributor Author

simensen commented Jun 2, 2026

Addressed in 89a7f9c — widened depends_on to [03, 05, 07, 08, 09, 15, 16, 19]. Step 15 brings make nix-smoke; step 16 brings make check-version-sync and make npm-pack-check; step 19 is the immediate predecessor (the build series end state). A strict scheduler reading the frontmatter now sees the full dependency surface that the verification block actually exercises.

@simensen simensen merged commit 8597405 into main Jun 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant