Skip to content

docs: reconcile license triad and accept DCO alongside Gitsign#18

Merged
prodnull merged 1 commit into
mainfrom
docs/license-and-signing-fix
Apr 19, 2026
Merged

docs: reconcile license triad and accept DCO alongside Gitsign#18
prodnull merged 1 commit into
mainfrom
docs/license-and-signing-fix

Conversation

@prodnull
Copy link
Copy Markdown
Owner

Summary

  • CONTRIBUTING.md §License said CC BY-NC-SA 4.0 (a non-commercial content license). LICENSE is Apache-2.0. Aligned CONTRIBUTING on Apache-2.0.
  • PR template said "dual license (Apache-2.0 OR MIT)". Dropped the MIT half; LICENSE has only Apache-2.0.
  • CONTRIBUTING required Gitsign for every commit; PR template simultaneously asked for DCO Signed-off-by. Relaxed CONTRIBUTING to accept either. Gitsign stays preferred for maintainers (enforce via branch protection on main if desired).

Triggered by PR #14 (external contribution) where @Strykar used DCO, flagged the triad inconsistency, and was otherwise ready to merge.

Test plan

  • CONTRIBUTING.md renders correctly, §License reads "Apache-2.0"
  • §Commit Signing offers Gitsign or DCO
  • .github/PULL_REQUEST_TEMPLATE.md checklist item mentions Apache-2.0 only, and mentions both signing options

🤖 Generated with Claude Code

Three files disagreed on what license prmana ships under and what
commit-provenance record contributors owe:

- LICENSE: Apache-2.0.
- CONTRIBUTING.md: CC BY-NC-SA 4.0 (a content license that forbids
  commercial use — completely wrong for OSS code).
- .github/PULL_REQUEST_TEMPLATE.md: "dual license (Apache-2.0 OR MIT)"
  plus "I have signed off my commits (DCO)".

LICENSE is authoritative. This commit aligns the other two on
Apache-2.0 and drops the phantom MIT half of the "dual license" line.

Signing: CONTRIBUTING.md required Gitsign; the PR template already
asked for DCO. External contributors to Linux-ecosystem projects
almost universally use DCO. Rather than turn away quality
contributions over a signing-format mismatch, the signing section
now accepts either Gitsign OR DCO (`git commit -s`). Gitsign remains
preferred for maintainer commits; that can be enforced via branch
protection on main rather than via CONTRIBUTING.md text.

@Strykar's PR #14 was DCO-signed. This change reconciles the
project's stated expectation with the commit-provenance form
external contributors actually use.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@prodnull prodnull merged commit af81027 into main Apr 19, 2026
1 check passed
@prodnull prodnull deleted the docs/license-and-signing-fix branch April 19, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant