Fix keyfile warning messages for non-critical files#2056
Closed
killerdevildog wants to merge 1 commit intoprofanity-im:masterfrom
Closed
Fix keyfile warning messages for non-critical files#2056killerdevildog wants to merge 1 commit intoprofanity-im:masterfrom
killerdevildog wants to merge 1 commit intoprofanity-im:masterfrom
Conversation
Resolves issue profanity-im#1911 by suppressing unimportant warning messages for missing keyfiles that are normal to not exist during initial runs. Changes: - Added load_custom_keyfile_quiet() function to src/common.h/c - Modified _load_keyfile() to accept suppress_missing_warnings parameter - Updated bookmark_ignore.c to use quiet loading for bookmark_ignore file - Updated tlscerts.c to use quiet loading for tlscerts file Missing files now log as debug messages instead of warnings for: - ~/.local/share/profanity/bookmark_ignore - ~/.local/share/profanity/tlscerts Important keyfiles still show warnings when missing to maintain proper error visibility for critical configuration files.
Member
|
We might just create those files. |
Member
|
@killerdevildog thanks for your contribution ! We chose to use another way to fix the issue. But we hope you will stay with Profanity and create more PRs :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #1911 by suppressing unimportant warning messages for missing keyfiles that are normal to not exist during initial runs.
Changes:
Missing files now log as debug messages instead of warnings for:
Important keyfiles still show warnings when missing to maintain proper error visibility for critical configuration files.
How to test the functionality
compile with make / configure first
use the command "./profanity