Fix issues found by building with gccs -fanalyzer

meson.build

@@ -65,7 +65,13 @@ if is_debug
     '-Wunused',
     '-Wall',
     '-Wextra',
+    '-fstack-protector-strong',
+    '-D_FORTIFY_SOURCE=2',
+    '-Og'
   ], language: 'c')
+  if cc.get_id() == 'gcc'
+     add_project_arguments('-fanalyzer', language: 'c')
+  endif
 endif
 
 if cc.get_id() == 'clang'

src/chatlog.c

@@ -418,7 +418,7 @@ _create_chatlog(const char* const other, const char* const login)
     GDateTime* now = g_date_time_new_now_local();
     auto_char char* filename = _get_log_filename(other, login, now, FALSE);
 
-    struct dated_chat_log* new_log = malloc(sizeof(struct dated_chat_log));
+    struct dated_chat_log* new_log = g_new0(struct dated_chat_log, 1);
     new_log->filename = strdup(filename);
     new_log->date = now;
 
@@ -431,7 +431,7 @@ _create_groupchat_log(const char* const room, const char* const login)
     GDateTime* now = g_date_time_new_now_local();
     auto_char char* filename = _get_log_filename(room, login, now, TRUE);
 
-    struct dated_chat_log* new_log = malloc(sizeof(struct dated_chat_log));
+    struct dated_chat_log* new_log = g_new0(struct dated_chat_log, 1);
     new_log->filename = strdup(filename);
     new_log->date = now;
 

src/command/cmd_ac.c

@@ -1653,101 +1653,86 @@ cmd_ac_uninit(void)
 }
 
 static void
-_filepath_item_free(char** ptr)
+_filepath_item_free(gchar** ptr)
 {
-    char* item = *ptr;
-    free(item);
+    gchar* item = *ptr;
+    g_free(item);
 }
 
 char*
 cmd_ac_complete_filepath(const char* const input, char* const startstr, gboolean previous)
 {
-    unsigned int output_off = 0;
-    char* tmp = NULL;
-
     // strip command
-    char* inpcp = (char*)input + strlen(startstr);
-    while (*inpcp == ' ') {
-        inpcp++;
+    char* inpcp_ptr = (char*)input + strlen(startstr);
+    while (*inpcp_ptr == ' ') {
+        inpcp_ptr++;
     }
 
-    inpcp = strdup(inpcp);
+    auto_gchar gchar* inpcp = g_strdup(inpcp_ptr);
+    if (!inpcp) {
+        return NULL;
+    }
 
     // strip quotes
-    if (*inpcp == '"') {
-        tmp = strrchr(inpcp + 1, '"');
-        if (tmp) {
-            *tmp = '\0';
+    if (inpcp[0] == '"') {
+        char* last_quote = strrchr(inpcp + 1, '"');
+        if (last_quote) {
+            *last_quote = '\0';
         }
-        tmp = strdup(inpcp + 1);
-        free(inpcp);
-        inpcp = tmp;
-        tmp = NULL;
+        gchar* unquoted = g_strdup(inpcp + 1);
+        inpcp = unquoted;
     }
 
-    // expand ~ to $HOME
-    if (inpcp[0] == '~' && inpcp[1] == '/') {
-        char* home = getenv("HOME");
-        if (!home) {
-            free(inpcp);
-            return NULL;
-        }
-        tmp = g_strdup_printf("%s/%sfoo", home, inpcp + 2);
-        output_off = strlen(home) + 1;
-    } else {
-        tmp = g_strdup_printf("%sfoo", inpcp);
-    }
-    free(inpcp);
-    if (!tmp) {
+    auto_gchar gchar* expanded = get_expanded_path(inpcp);
+    if (!expanded) {
         return NULL;
     }
 
-    char* foofile = strdup(basename(tmp));
-    char* directory = strdup(dirname(tmp));
-    g_free(tmp);
+    auto_gchar gchar* foofile = g_path_get_basename(expanded);
+    auto_gchar gchar* directory = g_path_get_dirname(expanded);
+
+    // If the input ends with a slash, the basename will be "." or "/"
+    // In that case, we are looking for all files in that directory
+    gboolean find_all = FALSE;
+    if (inpcp[strlen(inpcp) - 1] == '/') {
+        find_all = TRUE;
+    }
 
-    GArray* files = g_array_new(TRUE, FALSE, sizeof(char*));
+    GArray* files = g_array_new(TRUE, FALSE, sizeof(gchar*));
     g_array_set_clear_func(files, (GDestroyNotify)_filepath_item_free);
 
     DIR* d = opendir(directory);
     if (d) {
         struct dirent* dir;
 
         while ((dir = readdir(d)) != NULL) {
-            if (strcmp(dir->d_name, ".") == 0) {
+            if (strcmp(dir->d_name, ".") == 0 || strcmp(dir->d_name, "..") == 0) {
                 continue;
-            } else if (strcmp(dir->d_name, "..") == 0) {
+            }
+
+            // check if it matches prefix
+            if (!find_all && !g_str_has_prefix(dir->d_name, foofile)) {
                 continue;
-            } else if (*(dir->d_name) == '.' && *foofile != '.') {
-                // only show hidden files on explicit request
+            }
+
+            // only show hidden files on explicit request
+            if (dir->d_name[0] == '.' && (find_all || foofile[0] != '.')) {
                 continue;
             }
 
-            char* acstring = NULL;
-            if (output_off) {
-                tmp = g_strdup_printf("%s/%s", directory, dir->d_name);
-                if (tmp) {
-                    acstring = g_strdup_printf("~/%s", tmp + output_off);
-                    g_free(tmp);
-                }
-            } else if (strcmp(directory, "/") == 0) {
+            auto_gchar gchar* acstring = NULL;
+            if (strcmp(directory, "/") == 0) {
                 acstring = g_strdup_printf("/%s", dir->d_name);
             } else {
                 acstring = g_strdup_printf("%s/%s", directory, dir->d_name);
             }
-            if (!acstring) {
-                g_array_free(files, TRUE);
-                free(foofile);
-                free(directory);
-                return NULL;
-            }
 
-            g_array_append_val(files, acstring);
+            if (acstring) {
+                g_array_append_val(files, acstring);
+            }
         }
         closedir(d);
     }
-    free(directory);
-    free(foofile);
 
     autocomplete_update(filepath_ac, (char**)files->data);
     g_array_free(files, TRUE);

src/command/cmd_defs.c

@@ -2976,8 +2976,14 @@ command_docgen(void)
         cmds = g_list_insert_sorted(cmds, (gpointer)pcmd, (GCompareFunc)_cmp_command);
     }
 
-    FILE* toc_fragment = fopen("toc_fragment.html", "w");
-    FILE* main_fragment = fopen("main_fragment.html", "w");
+    auto_FILE FILE* toc_fragment = fopen("toc_fragment.html", "w");
+    auto_FILE FILE* main_fragment = fopen("main_fragment.html", "w");
+
+    if (!toc_fragment || !main_fragment) {
+        printf("\nError opening html files: %s.\n", strerror(errno));
+        g_list_free(cmds);
+        return;
+    }
 
     fputs("<ul><li><ul><li>\n", toc_fragment);
     fputs("<hr>\n", main_fragment);
@@ -3045,8 +3051,6 @@ command_docgen(void)
 
     fputs("</ul></ul>\n", toc_fragment);
 
-    fclose(toc_fragment);
-    fclose(main_fragment);
     printf("\nProcessed %d commands.\n\n", g_list_length(cmds));
     g_list_free(cmds);
 }