fix: Ignore self-presence for untracked MUC rooms#2097
Merged
Conversation
Only handle self-presence for rooms we are actively managing. Earlier we blindly react to any self-presence stanza by calling 'ui_room_join'. The join could have been initiated by another client or an external Gateway. In the case of #731 this was Slack. I remember that more people reported this kind of bug in our MUC. We then would open a window and the nick would be (null) because we don't have any nickname for that room set. So only react on self-presence if we manage the MUC. Other XMPP clients do the same. Fix #731
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only handle self-presence for rooms we are actively managing.
Earlier we blindly react to any self-presence
stanza by calling 'ui_room_join'.
The join could have been initiated by another client or an external Gateway. In the case of #731 this was Slack.
I remember that more people reported this kind of bug in our MUC.
We then would open a window and the nick would be (null) because we don't have any nickname for that room set.
So only react on self-presence if we manage the MUC. Other XMPP clients do the same.
Fix #731