Conversation
Member
Author
Member
Author
|
I'll need to go now. I'll continue later. |
jubalh
changed the title
jubalh
force-pushed
the
fix/2098
branch
2 times, most recently
from
def2b85 to
33bb007
Compare
Fix several issues in cmd_ac_complete_filepath: * Prevent a segfault when input is empty. * Fix a double free where acstring was managed by both auto_gchar and GArray. * Fix a memory leak when reassigning inpcp during quote stripping. * Restore the ability to cycle through files on repeated TAB presses by caching the last input and skipping updates if the input is already a known completion. * Preserve user input style (e.g. ~, ./) in autocompletion strings to ensure matches are correctly displayed and filtered. Bug got introduced when "cleaning" code with new compiler flags and sanitizers: aec8e48. Add unit tests so this doesn't happen again. Before that commit we didn't use the static variable but used autocomplete_update instead. Now we avoid redundat updates and preserve the state across tab presses. We should look at this again later. Fix #2098
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2098