Conversation
sjaeckel
reviewed
Mar 9, 2026
Comment on lines
+1000
to
+1019
| GList* curr = values; | ||
| while (curr) { | ||
| ProfWin* window = curr->data; | ||
| if (window->type == WIN_CHAT) { | ||
| ProfChatWin* chatwin = (ProfChatWin*)window; | ||
| if (jid == NULL || strcmp(chatwin->barejid, jid) == 0) { | ||
| #ifdef HAVE_OMEMO | ||
| chatwin->omemo_trusted = omemo_is_jid_trusted(chatwin->barejid); | ||
| #endif | ||
| } | ||
| } else if (window->type == WIN_MUC) { | ||
| ProfMucWin* mucwin = (ProfMucWin*)window; | ||
| if (jid == NULL || strcmp(mucwin->roomjid, jid) == 0) { | ||
| #ifdef HAVE_OMEMO | ||
| mucwin->omemo_trusted = omemo_is_jid_trusted(mucwin->roomjid); | ||
| #endif | ||
| } | ||
| } | ||
| curr = g_list_next(curr); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| GList* curr = values; | |
| while (curr) { | |
| ProfWin* window = curr->data; | |
| if (window->type == WIN_CHAT) { | |
| ProfChatWin* chatwin = (ProfChatWin*)window; | |
| if (jid == NULL || strcmp(chatwin->barejid, jid) == 0) { | |
| #ifdef HAVE_OMEMO | |
| chatwin->omemo_trusted = omemo_is_jid_trusted(chatwin->barejid); | |
| #endif | |
| } | |
| } else if (window->type == WIN_MUC) { | |
| ProfMucWin* mucwin = (ProfMucWin*)window; | |
| if (jid == NULL || strcmp(mucwin->roomjid, jid) == 0) { | |
| #ifdef HAVE_OMEMO | |
| mucwin->omemo_trusted = omemo_is_jid_trusted(mucwin->roomjid); | |
| #endif | |
| } | |
| } | |
| curr = g_list_next(curr); | |
| } | |
| #ifdef HAVE_OMEMO | |
| GList* curr = values; | |
| while (curr) { | |
| ProfWin* window = curr->data; | |
| if (window->type == WIN_CHAT) { | |
| ProfChatWin* chatwin = (ProfChatWin*)window; | |
| if (jid == NULL || strcmp(chatwin->barejid, jid) == 0) { | |
| chatwin->omemo_trusted = omemo_is_jid_trusted(chatwin->barejid); | |
| } | |
| } else if (window->type == WIN_MUC) { | |
| ProfMucWin* mucwin = (ProfMucWin*)window; | |
| if (jid == NULL || strcmp(mucwin->roomjid, jid) == 0) { | |
| mucwin->omemo_trusted = omemo_is_jid_trusted(mucwin->roomjid); | |
| } | |
| } | |
| curr = g_list_next(curr); | |
| } | |
| #endif |
No need to run this at all if there's no OMEMO.
sjaeckel
reviewed
Mar 9, 2026
Member
sjaeckel
left a comment
sjaeckel
left a comment
There was a problem hiding this comment.
Still leaving this here, even though it's already merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a26cdf3 / #2104 added OMEMO trust status to the title bar, but it was being re-calculated on UI refresh.
Update only on certain operations (like
/omemo trust, new device discoveries and even incoming OMEMO messages for example).