Merged
Conversation
When sending OMEMO messages, we print a warning message for every participant without a device ID on every single send: ``` Can't find a OMEMO device id for my@jid.org ``` This clutters the UI due to the high volume of repetitive information. This is solved by tracking suppressed warnings within the window structure. A warning for a specific JID and type is only shown once per window context. Suppression state is stored in the base ProfWin structure and managed via helper functions (win_warn_needed, win_warn_sent). The state is lazily initialized to save resources and automatically cleaned up when the window is closed. Warnings are explicitly reset when an OMEMO session is started or ended to ensure users see fresh alerts when toggling encryption.
Removing the UI notification in omemo_start_device_session to reduce noise during /omemo start. The information is still available in the debug logs. And I think for existing sessions its just too much without value. Ref: b20e3f1
Modify omemo_set_device_list to check against the persistent known_devices.txt file before notifying the user. This prevents false-positive security alerts on every restart for devices that have already been registered and trusted. Check against the persistent known_devices.txt file before notifying the user. This ensures that "New OMEMO device" alerts are only shown for devices that are truly new to this client. Ref: ce9b514
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves upon #2104
The messages in that PR were not polished enough. Too much noise was generated.
Can't find a OMEMO device id for my@jid.orgonce per context/omemo startNew OMEMO deviceby comparing to state on diskRef: a26cdf3