Conversation
a4cbf3e removed macOS from the CI. We couldn't get it to build and no community member stepped up. So let's remove this file now as well.
There once was OpenBSD CI from sr.ht sponsored by wstrm. It's not available since a log time. So let's drop it.
jubalh
force-pushed
the
ci
branch
4 times, most recently
from
152e378 to
dff12b0
Compare
Have a better overview, we are interested in which tests are run, which distro, which build system and which omemo backend. debian | Autotools | unit+func | signal debian | Meson | unit+func | signal debian | Meson | unit+func | libomemo fedora | Autotools | unit+func | signal ubuntu | Autotools | unit+func | signal
Remove stabber from Dockerfiles were we only build with autotools.
Locally valgrind is quiet. But on CI valgrind complains. This is due to an older valgrind version which doesn't handle AVX2-optimized strings properly. So we need to add it to the suppression file.
Triggered by unit tests. In Profanity itself the situation is probably rarely happening. We would have to disconnect/exit after receiving presence but before the roster arrives.
Instead of: ``` CI / Check coding style CI / Check spelling CI / debian | Autotools | unit | signal CI / debian | Meson | unit+func | libomemo CI / debian | Meson | unit+func | signal CI / fedora | Autotools | unit | signal CI / ubuntu | Autotools | unit | signal Cygwin / cygwin-build ``` We will sort them into "Style", "Linux" and "Cygwin".
This will result in smaller and cleaner tarballs for distributions to use.
Additionally it is a logical step towards moving fully to the Meson build system.
While the last release provided two tarballs (one generated with
Autotools and one with Meson), the next release will only provide a
Meson-generated tarball.
These attributes are respected by `git archive` and `meson dist` which
means they will take effect for the Meson generated tarballs and the
GitHub autogenerated tarballs as well.
As a consequence of switching to `meson dist`, pre-generated files like
`configure` will no longer be included in the tarballs. Users and
distributions that still wish to use the Autotools build system from
these tarballs will now need to run `./bootstrap.sh` or `autoreconf -fi`
themselves, which requires automake, autoconf, and libtool to be
installed.
Since many distributions are slowly dropping the usage of vendor
generated tarballs and are moving to checking out git tags this should
not be a problem.
Arch Linux is for example doing
`source=("git+https://github.com/user/project.git#tag=v1.2.3")` and
Debian has the `git-buildpackage` too. So both of them require require
autoreconf already.
Autotools support might be removed entirely in a future
release since I find them much easier to edit and maintain.
Explain the how and why in CONTRIBUTING.md Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Disable the functional tests in the case of meson as well. They don't seem to work in the CI or take too long. This needs further investigation. For now let's run them locally and before each release. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.