Fix incorrect omemo decryption error for Key Transport Messages #2130
Merged
Fix incorrect omemo decryption error for Key Transport Messages #2130
Conversation
Correctly handle OMEMO stanzas that contain a <header> but no <payload>. These "Key Transport Messages" (heartbeats) are used by some clients for session maintenance and establishing trust. Ref: a2726b6 made the <payload> element mandatory in the parser. Ref: 4d49c2b the bug became user-visible. Fixes: #2129 Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Centralize heartbeat detection and have a function for error to string mapping. So we don't need the same code in multiple handlers. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
jubalh
force-pushed
the
fix/omemo-false-cannot-decrypt-msg
branch
from
7dad5d0 to
a824b26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly handle OMEMO stanzas that contain a
<header>but no<payload>.These "Key Transport Messages" (heartbeats) are used by some clients
for session maintenance and establishing trust.
Ref: a2726b6 made the element mandatory in the parser.
Ref: 4d49c2b the bug became user-visible.
Fixes: #2129