fix(omemo): add missing includes for libomemo-c builds#2133
Merged
jubalh merged 1 commit intoprofanity-im:masterfrom Mar 27, 2026
Merged
fix(omemo): add missing includes for libomemo-c builds#2133jubalh merged 1 commit intoprofanity-im:masterfrom
jubalh merged 1 commit intoprofanity-im:masterfrom
Conversation
Signed-off-by: Leon Adomaitis <leon@adomaitis.de>
Member
|
Thank you! |
Member
|
@GunniBusch would you be interested in adding a macOS homebrew build to our CI? |
Contributor
Author
Sure. I can try. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes some missing
libomemo-cimports and usages ofHAVE_LIBOMEMO_Cbefore importconfig.h.The reason for this pr is the failing homebrew build: Homebrew/homebrew-core#274439
Changes by file
src/omemo/crypto.h: add missinglibomemo-cimports (selection viaHAVE_LIBOMEMO_C) and importconfig.h(forHAVE_LIBOMEMO_C)src/omemo/store.h: add missinglibomemo-cimports (selection viaHAVE_LIBOMEMO_C)src/omemo/store.c: moveconfig.hbefore the conditional include so the compile-time flag is defined before header selection.