fix(omemo): standardize PreKey management to prevent decryption failures#2137
Merged
fix(omemo): standardize PreKey management to prevent decryption failures#2137
Conversation
Standardize how PreKeys are handled during OMEMO message reception to align with XEP-0384 best practices. Previously Profanity replaced a consumed PreKey by generating a new one with the same ID. This behavior could lead to decryption failures if multiple senders attempted to use the same PreKey ID before the client could successfully update its bundle on the server. Remove consumed PreKeys from the local store. New PreKeys are generated in batches (100) when the local supply runs low (< 10). Republish OMEMO bundle after replenishment. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize how PreKeys are handled during OMEMO message reception to align with XEP-0384 best practices.
Previously Profanity replaced a consumed PreKey by generating a new one with the same ID. This behavior could lead to decryption failures if multiple senders attempted to use the same PreKey ID before the client could successfully update its bundle on the server.
Remove consumed PreKeys from the local store.
New PreKeys are generated in batches (100) when the local supply runs low (< 10).
Republish OMEMO bundle after replenishment.