Conversation
Member
Author
|
@sezuan please test. |
When we wanted to adhere better to the XEPs we actually did a mistake. In commit 421bb2e (so the mistake is there since 0.17.0), a check was added to only request receipts if support was confirmed via entity capabilities. This was too restrictive as it defaulted to 'not supported' when capabilities were not yet cached (new sessions or bare JIDs). Following XEP-0184 recommendations, we now only omit the receipt request if we have positive knowledge that the contact does not support it. If capabilities are unknown, we follow the users preference. Fixes: #2157 Ref: 421bb2e Signed-off-by: Michael Vetter <jubalh@iodoru.org>
|
Works! Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we wanted to adhere better to the XEPs we actually did a mistake.
In commit 421bb2e (so the mistake is there since 0.17.0), a check was added to only request receipts if
support was confirmed via entity capabilities. This was too restrictive as it defaulted to 'not supported' when capabilities were not yet cached (new sessions or bare JIDs).
Following XEP-0184 recommendations, we now only omit the receipt request if we have positive knowledge that the contact does not support it. If capabilities are unknown, we follow the users preference.
Ref: 421bb2e