Skip to content

Fix column names in EstimatePublicLinkService queries #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proforcetech merged 1 commit into from
Dec 29, 2025
Merged

Fix column names in EstimatePublicLinkService queries #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Services/Estimate/EstimatePublicLinkService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,10 +311,10 @@ private function propagateEstimateStatus(int $estimateId): void
*/
private function fetchJobsWithItems(int $estimateId): array
{
$jobsStmt = $this->connection->pdo()->prepare('SELECT * FROM estimate_jobs WHERE estimate_id = :estimate_id ORDER BY position ASC');
$jobsStmt = $this->connection->pdo()->prepare('SELECT * FROM estimate_jobs WHERE estimate_id = :estimate_id ORDER BY display_order ASC');
$jobsStmt->execute(['estimate_id' => $estimateId]);

$itemStmt = $this->connection->pdo()->prepare('SELECT * FROM estimate_items WHERE job_id = :job_id ORDER BY position ASC');
$itemStmt = $this->connection->pdo()->prepare('SELECT * FROM estimate_items WHERE estimate_job_id = :job_id ORDER BY id ASC');

$results = [];
foreach ($jobsStmt->fetchAll(PDO::FETCH_ASSOC) as $jobRow) {
Expand Down
Loading