fix(ci): finish shell-injection removal + re-enable semgrep --error#11
Merged
Conversation
…e semgrep --error Completes #10: the Chocolatey job's Determine version / Submit / Summary steps and both Linux/Chocolatey Summary steps still interpolated github.event.inputs.* directly in run: blocks. Move them all into step-level env: vars referenced as quoted shell variables, and restore --error on semgrep so findings block CI. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ralyodio
added a commit
that referenced
this pull request
May 30, 2026
- Replace the final 'USER root' + RUN chmod with 'COPY --chmod=755', so the container no longer ends as root (semgrep dockerfile.security.last-user-is-root, the last ERROR finding blocking the Security workflow after #11 restored --error). - Add .claude/ to .gitignore so local Claude config (which has held tokens) is never committed again. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ralyodio
added a commit
that referenced
this pull request
May 30, 2026
…e semgrep --error (#11) Completes #10: the Chocolatey job's Determine version / Submit / Summary steps and both Linux/Chocolatey Summary steps still interpolated github.event.inputs.* directly in run: blocks. Move them all into step-level env: vars referenced as quoted shell variables, and restore --error on semgrep so findings block CI. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ralyodio
added a commit
that referenced
this pull request
May 30, 2026
- Replace the final 'USER root' + RUN chmod with 'COPY --chmod=755', so the container no longer ends as root (semgrep dockerfile.security.last-user-is-root, the last ERROR finding blocking the Security workflow after #11 restored --error). - Add .claude/ to .gitignore so local Claude config (which has held tokens) is never committed again. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes #10. The Chocolatey job steps and both Summary steps in submit-packages.yml still interpolated
github.event.inputs.*directly inrun:blocks; moved all into step-levelenv:vars referenced as quoted shell variables. Restored--erroron semgrep so real findings block CI again.🤖 Generated with Claude Code