Skip to content

feat(browser-firefox): emit firefox-package-plan.json on dry-run builds#189

Open
hikaruhuimin wants to merge 2 commits into
profullstack:masterfrom
hikaruhuimin:dry-run/browser-firefox
Open

feat(browser-firefox): emit firefox-package-plan.json on dry-run builds#189
hikaruhuimin wants to merge 2 commits into
profullstack:masterfrom
hikaruhuimin:dry-run/browser-firefox

Conversation

@hikaruhuimin
Copy link
Copy Markdown
Contributor

Closes #173

/claim #173

Summary

  • write an inspectable firefox-package-plan.json artifact for dry-run browser-firefox builds
  • record resolved source directory, expected AMO zip artifact, channel, version, extension id, and exact web-ext build argv command
  • keep dry-run shipping side-effect free while returning resolved source/channel metadata
  • preserve the existing real-build artifact path and attach the resolved web-ext command metadata

Verification

  • pnpm exec vitest run packages/targets/browser-firefox/src/index.test.ts
  • pnpm --filter @profullstack/sh1pt-target-browser-firefox typecheck
  • pnpm --filter @profullstack/sh1pt typecheck
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

browser-firefox dry-run builds should emit a package plan

1 participant