Skip to content

Add MCP server tool call adapter#216

Open
SimoneMariaRomeo wants to merge 3 commits into
profullstack:masterfrom
SimoneMariaRomeo:codex/sh1pt-mcp-server-calls
Open

Add MCP server tool call adapter#216
SimoneMariaRomeo wants to merge 3 commits into
profullstack:masterfrom
SimoneMariaRomeo:codex/sh1pt-mcp-server-calls

Conversation

@SimoneMariaRomeo
Copy link
Copy Markdown

Summary

  • add a first-class MCP server adapter contract in core, including a stdio JSON-RPC tools/call helper
  • register a new mcp-servers CLI adapter category
  • add @profullstack/sh1pt-mcp-server-penpot, defaulting to npx -y @penpot/mcp@stable with local/remote setup guidance
  • add an MCP server contract test plus a fake stdio MCP server test for the Penpot adapter

Validation

  • pnpm --filter @profullstack/sh1pt-core typecheck
  • pnpm --filter @profullstack/sh1pt typecheck
  • pnpm --filter @profullstack/sh1pt-mcp-server-penpot typecheck
  • pnpm vitest run packages/mcp-servers/penpot/src/index.test.ts
  • git diff --check

Closes #214

Copy link
Copy Markdown
Contributor

@ralyodio ralyodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are oh publishing new npm packages?

@SimoneMariaRomeo
Copy link
Copy Markdown
Author

Handled this by making the Penpot MCP wrapper workspace-private instead of publish-ready.

Change in 4b98028:

  • added "private": true
  • removed prepublishOnly
  • removed the package files publish hint

The new core MCP stdio contract remains usable, but this PR no longer asks npm to publish a new Penpot package unless you later decide that adapter should become public.

Validation rerun:

  • pnpm --filter @profullstack/sh1pt-mcp-server-penpot typecheck
  • pnpm --filter @profullstack/sh1pt-core typecheck
  • pnpm vitest run packages/mcp-servers/penpot/src/index.test.ts
  • git diff --check

@ralyodio
Copy link
Copy Markdown
Contributor

It should be public do we not already have a sh1pt npm module for integrations for use programmatically? That was the idea and point of integration

@SimoneMariaRomeo
Copy link
Copy Markdown
Author

You're right. I misread the first review note as "avoid publishing this package", but the issue text and the existing adapter pattern point to this being a public provider adapter.

Pushed 7c2eff9 to restore the public package shape for @profullstack/sh1pt-mcp-server-penpot:

  • removed private: true
  • restored prepublishOnly
  • restored files: ["dist"]

The programmatic integration contract remains in @profullstack/sh1pt-core; the Penpot package is the public provider adapter, matching the existing @profullstack/sh1pt-<category>-<provider> pattern.

Validation rerun:

  • pnpm --filter @profullstack/sh1pt-mcp-server-penpot typecheck
  • pnpm --filter @profullstack/sh1pt-core typecheck
  • pnpm --filter @profullstack/sh1pt-mcp-server-penpot build
  • pnpm vitest run packages/mcp-servers/penpot/src/index.test.ts
  • git diff --check

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Preshy Preshy closed this May 15, 2026
@Preshy Preshy reopened this May 15, 2026
@ralyodio ralyodio self-assigned this May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add support for mcp server calls

4 participants