Expose all existing target adapters in CLI registry#220
Open
moishadzh-code wants to merge 3 commits into
Open
Conversation
Sync the targets adapter list with packages/targets so every existing target package is reachable from sh1pt targets list/setup.
Assert that the CLI targets registry stays in sync with packages/targets.
Include payment in TargetKind so existing packages/targets/payment-* adapters are covered by the core target type.
Author
|
Follow-up note: I added a small third commit for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
targetsadapter registry with every directory currently present inpackages/targetscategoryById('targets')against the filesystem listFixes #219
Testing
targets.adaptersagainstpackages/targets: 66 registered, 66 directories, no missing or extra adapters.pnpm testlocally because this environment does not exposepnpm/npmin PATH.