feat(cli): sync targets adapter registry with packages/targets filesystem#223
Open
emil07770 wants to merge 1 commit into
Open
feat(cli): sync targets adapter registry with packages/targets filesystem#223emil07770 wants to merge 1 commit into
emil07770 wants to merge 1 commit into
Conversation
…stem Closes profullstack#219. Addresses profullstack#133. The CATEGORIES registry in adapter-registry.ts listed only 42 of the 66 directories under packages/targets/, meaning commands such as `sh1pt targets browser-edge info`, `sh1pt targets plugin-vscode info`, `sh1pt targets sdk-pypi info`, and 23 others were silently unregistered. Adds the 24 missing adapters, grouped by kind with inline comments so future additions are easy to place: browser-edge, browser-firefox, browser-safari deploy-coolify, deploy-lambda exe-dev mobile-android payment-adyen, payment-coinpay, payment-paypal, payment-square, payment-stripe pkg-apt, pkg-aur, pkg-flatpak, pkg-nix, pkg-perry, pkg-scoop, pkg-snap, pkg-winget plugin-jetbrains, plugin-vscode qa-geisterhand sdk-pypi Also adds a 6-test Vitest regression suite (adapter-registry.test.ts) that reads packages/targets/ at test time and fails if any directory is not registered or if any registered adapter no longer exists on disk, so the registry can't silently drift again. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #219. Addresses #133.
The
CATEGORIESregistry inadapter-registry.tslisted only 42 of the 66 directories underpackages/targets/, meaning commands such assh1pt targets browser-edge info,sh1pt targets plugin-vscode info,sh1pt targets sdk-pypi info, and 21 others were silently unregistered.Missing adapters added (24 total)
browser-edge,browser-firefox,browser-safarideploy-coolify,deploy-lambdaexe-devmobile-androidpayment-adyen,payment-coinpay,payment-paypal,payment-square,payment-stripepkg-apt,pkg-aur,pkg-flatpak,pkg-nix,pkg-perry,pkg-scoop,pkg-snap,pkg-wingetplugin-jetbrains,plugin-vscodeqa-geisterhandsdk-pypiRegression prevention
Adds
adapter-registry.test.tswith 6 tests:targetsregistry contains allpackages/targets/directories (fails if a new target is added without updating the registry)targetsregistry has no phantom entries (fails if a registered adapter no longer exists on disk)pkgPrefixanddescriptionThe FS-diff tests gracefully skip in shallow CI checkouts (
readdirSyncreturns[]), so they don't break the test suite in environments that don't clone the full monorepo.Test plan
pnpm exec vitest run packages/cli/src/adapter-registry.test.ts— 6/6 passpnpm --filter @profullstack/sh1pt typecheck— no errorsgit diff --check— no trailing whitespace🤖 Generated with Claude Code